git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/3] untracked cache: fix entry invalidation

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 25, 2015, 20:12 UTC
Message-ID
<xmqqr3mrxh2v.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1440530701.7859.3.camel@twopensource.com>
David Turner <dturner@twopensource.com> writes:
Show 14 quoted lines
> On Wed, 2015-08-19 at 20:01 +0700, Nguyễn Thái Ngọc Duy wrote:
>> First, the current code in untracked_cache_invalidate_path() is wrong
>> because it can only handle paths "a" or "a/b", not "a/b/c" because
>> lookup_untracked() only looks for entries directly under the given
>> directory. In the last case, it will look for the entry "b/c" in
>> directory "a" instead. This means if you delete or add an entry in a
>> subdirectory, untracked cache may become out of date because it does not
>> invalidate properly. This is noticed by David Turner.
>> 
>> The second problem is about invalidation inside a fully untracked/excluded
>> directory. In this case we may have to invalidate back to root. See the
>> comment block for detail.
>
> LGTM.
Thanks, both.  Let's move this forward.
Previous: David TurnerNext: Junio C Hamano
Message 9 of 10 in “untracked-cache: fix subdirectory handling”
  1. untracked-cache: fix subdirectory handlingDavid Turner, Aug 16, 2015
  2. Duy NguyenAug 16, 2015
  3. Duy NguyenAug 19, 2015
  4. 0/3 dt/untracked-subdirNguyễn Thái Ngọc Duy, Aug 19, 2015
  5. 1/3 t7063: use --force-untracked-cache to speed up a bitNguyễn Thái Ngọc Duy, Aug 19, 2015
  6. 2/3 untracked-cache: fix subdirectory handlingNguyễn Thái Ngọc Duy, Aug 19, 2015
  7. 3/3 untracked cache: fix entry invalidationNguyễn Thái Ngọc Duy, Aug 19, 2015
  8. David TurnerAug 25, 2015
  9. Junio C HamanoAug 25, 2015
  10. Junio C HamanoAug 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.