Re: [PATCH] Store EXC_FLAG_* values in unsigned integers
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 1, 2016, 18:26 UTC
- Message-ID
- <xmqqr3fu6omz.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1456851779-38548-1-git-send-email-sauravsachidanand@gmail.com>
Saurav Sachidanand <sauravsachidanand@gmail.com> writes:
> The values defined by the macro EXC_FLAG_* (1, 4, 8, 16) are > stored in fields of the structs "pattern" and “exclude”, some > functions arguments and a local variable.
It's a minor point, but it is somewhat irritating that "pattern" is enclosed in a regular dq pair while "exclude" is in a fancy dq pair. I think our log messages tend to prefer the regular ones.
No need to resend; thanks.