Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

From: Junio C Hamano <gitster@pobox.com>
Date: May 4, 2016, 19:06 UTC
Message-ID: <xmqqr3dhhcd7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <17d30bb680a0452efd7b3c4f42e2f94478a86273.1462372716.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 12 quoted lines

> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index b2d8d40..c4269ac 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -370,6 +370,7 @@ int init_db(const char *template_dir, unsigned int flags)
>  	check_repository_format();
>  
>  	reinit = create_default_files(template_dir);
> +	mark_as_git_dir(get_git_dir());
>  
>  	create_object_directory();
>

I agree with the goal of the change, but I am having a hard time justifying this addition. Primarily because I do not understand the need for this.

In order to be prepared to handle HIDE_DOTFILES_TRUE case, mingw_mkdir() needs to be taught about needs_hiding() and make_hidden() already. Why isn't it sufficient to teach needs_hiding() to check with !strcmp(basename(path, ".git")) under HIDE_DOTFILES_DOTGITONLY?

I do not understand why core.hideDotFiles needs to be explicitly copied to the config file in the resulting repository, either.

Once you created a repository, Git won't unhide the hidden .git of that reposiotry, so the idea must be to propagate the setting to a new repository that will further be created, but wouldn't that get the "please hide" preference from the same place as we have got the preference to hide .git when the current repository was created anyway?