Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2016, 21:18 UTC
Message-ID: <xmqqr3bsvpwu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq37o8x514.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> LE Manh Cuong <cuong.manhle.vn@gmail.com> writes:
>
>> It's really a good commit message, better than mine.
>>
>> So must I make another patch or you will update the commit message?
>>
>> PS: This is the first time I submit a patch to Git, so forgive me
>> if I made any silly questions.
>
> I can locally amend by replacing the log message when I queue your
> original patch, now we seem to have agreed how it should read.
>
> Thanks.

By the way, here is the hits from

	$ git grep '^[    ]*: ${' master

All of them in t/t4100/* and contrib/examples do not need touching. But others are in the same boat as what you updated in this patch, i.e. "wasteful -- the no-op invocation do not need its $VAR expanded".

contrib/examples/git-reset.sh:: ${rev=HEAD} contrib/hooks/post-receive-email:: ${diffopts:="--stat --summary --find-copies-harder"} git-mergetool--lib.sh:: ${MERGE_TOOLS_DIR=$(git --exec-path)/mergetools} git-quiltimport.sh:: ${QUILT_PATCHES:=patches} git-quiltimport.sh:: ${QUILT_SERIES:=$QUILT_PATCHES/series} git-rebase--interactive.sh:: ${comment_char:=#} git-sh-setup.sh: : ${LESS=-FRX} git-sh-setup.sh: : ${LV=-c} git-sh-setup.sh: : ${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"} git-submodule.sh:: ${GIT_ALLOW_PROTOCOL=file:git:http:https:ssh} git-web--browse.sh: : ${browser_path:="$1"} t/t1014-read-tree-confusing.sh: : ${pretty:=$path} t/t1450-fsck.sh: : ${pretty:=$path} t/t4100/t-apply-2.patch: : ${GIT_DIR=.git} t/t4100/t-apply-2.patch: : ${GIT_OBJECT_DIRECTORY="${SHA1_FILE_DIRECTORY-"$GIT_DIR/objects"}"} t/t4100/t-apply-6.patch: : ${GIT_DIR=.git} t/t4100/t-apply-6.patch: : ${GIT_OBJECT_DIRECTORY="${SHA1_FILE_DIRECTORY-"$GIT_DIR/objects"}"} t/test-lib.sh:: ${ASAN_OPTIONS=detect_leaks=0} t/valgrind/analyze.sh:: ${TEST_OUTPUT_DIRECTORY=$(dirname "$0")/..}