git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff_unique_abbrev(): document its assumtion and limitation

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2016, 17:08 UTC
Message-ID
<xmqqr37x743x.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20161001091558.guduirzlkog5fkzd@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I guess my point was that the poor name may have contributed to the need
> to explain it.

The comment was not about "it may not be obvious but this tries to pad and align", but to say "the way this tries to pad and align is based on an unsaid assumption that leads to this limitation". I do agree it is a good idea to rename it to a name that has 'pad' or 'align' in addition to 'unique', but I doubt renaming alone would reduce the need for the new comment.

Previous: Jeff King
Message 5 of 5 in “diff_unique_abbrev(): document its assumtion and limitation”
  1. diff_unique_abbrev(): document its assumtion and limitationJunio C Hamano, Sep 30, 2016
  2. Jeff KingSep 30, 2016
  3. Junio C HamanoSep 30, 2016
  4. Jeff KingOct 1, 2016
  5. Junio C HamanoOct 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.