Re: [PATCH 05/12] for_each_alternate_ref: replace transport code with for-each-ref

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 25, 2017, 19:00 UTC
Message-ID: <xmqqr33rars5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170124004409.py4eggvrtrej2bgi@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> ...
> This patch omits the peeled information from
> for_each_alternate_ref entirely, and leaves it up to the
> caller whether they want to dig up the information.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I also tried adding "%(*objectname)" to for-each-ref to just
> grab the peeled information, but the peel implementation in
> ref-filter is _really_ slow. It doesn't use the packed-ref
> peel information, and it doesn't recognize duplicates (so in
> the 80 million case, it really parses 80 million tags).

That's an interesting tangent that may want to be looked into.

>  transport.c | 48 ++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 38 insertions(+), 10 deletions(-)

The updated code is a more pleasant read.