Re: [PATCHv2] builtin/merge: honor commit-msg hook for merges

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2017, 23:43 UTC
Message-ID: <xmqqr2vj2y1b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kauB+AznEOwmNBQLbuz-szD3kYBHAJDmy0OWWEbxny9xQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 7 quoted lines

>> I also thought that we were hunting calls of cmd_foo() from outside
>> the git.c command dispatcher as grave errors and want to clean up
>> the codebase to get rid of them.
>
> ... but I did not account for this fact. (I was not aware of these being
> called grave errors, but assumed this is a good state. And why change
> a good state?)

https://public-inbox.org/git/20170830053108.g2xsn43rwulnwn3p@sigill.intra.peff.net/

gives a good explanation why it is not a good state.