Re: [WIP 04/15] upload-pack: convert to a builtin

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 6, 2017, 21:59 UTC
Message-ID: <xmqqr2s7frga.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171204235823.63299-5-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 5 quoted lines

> In order to allow for code sharing with the server-side of fetch in
> protocol-v2 convert upload-pack to be a builtin.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---

This looks obvious and straight-forward to a cursory look.

I vaguely recalled and feared that we on purpose kept this program separate from the rest of the system for a reason, but my mailing list search is coming up empty.

Show 19 quoted lines

>  Makefile      | 3 ++-
>  builtin.h     | 1 +
>  git.c         | 1 +
>  upload-pack.c | 2 +-
>  4 files changed, 5 insertions(+), 2 deletions(-)
> ...
> diff --git a/upload-pack.c b/upload-pack.c
> index ef99a029c..2d16952a3 100644
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -1033,7 +1033,7 @@ static int upload_pack_config(const char *var, const char *value, void *unused)
>  	return parse_hide_refs_config(var, value, "uploadpack");
>  }
>  
> -int cmd_main(int argc, const char **argv)
> +int cmd_upload_pack(int argc, const char **argv, const char *prefix)
>  {
>  	const char *dir;
>  	int strict = 0;

Shouldn't this file be moved to builtin/ directory, though?