Re: [PATCH v2 4/5] Move the reusable parts of memory pool into its own file

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2018, 20:27 UTC
Message-ID: <xmqqr2oaillr.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180323144408.213145-5-jamill@microsoft.com>

Jameson Miller <jamill@microsoft.com> writes:

Show 12 quoted lines

> This moves the reusable parts of the memory pool logic used by
> fast-import.c into its own file for use by other components.
>
> Signed-off-by: Jameson Miller <jamill@microsoft.com>
> ---
>  Makefile      |   1 +
>  fast-import.c | 118 +---------------------------------------------------------
>  mem-pool.c    | 103 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  mem-pool.h    |  34 +++++++++++++++++
>  4 files changed, 139 insertions(+), 117 deletions(-)
>  create mode 100644 mem-pool.c
>  create mode 100644 mem-pool.h

This step looks totally uncontroversial, provided that the result after [1-3/5] is in a reasonable shape ;-)

Hint for other reviewers.  This

    $ git blame -s -b -C HEAD^..HEAD mem-pool.c

can be used to see that most of the lines in this new file are imported verbatim from fast-import.c at the receiving end.