Re: [PATCH v4] log,diff-tree: add --combined-all-names option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 5, 2019, 18:04 UTC
- Message-ID
- <xmqqr2cmru0k.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CABPp-BGQ62Mj1jym8-xu5XKN6mJ65yq-QUqXjR-xx=AWFZgNbw@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
> I don't want to get rid of them; the initial reviews of my original > patch thought the format was ambiguous and would mishandle files with > tabs in them. But yeah, I can definitely add a few testcases without > FUNNYNAMES. Sorry for the headache; I'll fix this up.
Thanks, both. I was about to squash the fix from Dscho in, but I agree that it is a much better idea to cover the basics in separate tests that would run without FUNNYNAMES. Will hold and wait for your updates.
Thanks.