Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache

> Jonathan Tan wrote:
>>> 07c3c2aa16 ("tests: define GIT_TEST_SIDEBAND_ALL", 2019-01-16) added
>>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings
>>> from Apache when the variable is unset, as we do for GIT_VALGRIND* and
>>> GIT_TRACE, from f628825481 ("t/lib-httpd: handle running under
>>> --valgrind", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
>>> Apache", 2015-03-13), respectively.
>>> 
>>> Signed-off-by: Todd Zullinger <tmz@pobox.com>
>>> ---
>>> I missed this with rc0, but poking through build logs I noticed a number
>>> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'
>>> warnings.
>>> 
>>> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and
>>> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for
>>> things like GNUPGHOME.  But I could easily be wrong about that.
>> 
>> Thanks for looking into this. I think this is the right way to do it
>> too.
>> 
>> Previous discussion here [1] but I don't think any patches came out of
>> that.
>> 
>> [1] https://public-inbox.org/git/20190129232732.GB218214@google.com/
>
> Hah.  Somehow I missed that thread and Jeff's reply barely
> 24 hours before I sent this.  Hopefully this saves Jonathan
> Nieder a few minutes of patch prep & testing.