Re: Git status parse error after v.2.22.0 upgrade

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2019, 16:05 UTC
Message-ID: <xmqqr27xwjwj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190613093023.GA3919@ariake.ledovskis.lv>

aleksandrs@ledovskis.lv writes:

> My repo indeed contains a ".git/sequencer/todo" file which
> contains references to commits long-gone (i.e., rebased).
> Renaming or deleting this file stops whines about "error: could
> not parse".

Interesting. So in short, when the repository has leftover sequencer state file that is not in use, "git status parse" thing (whatever it is---are you getting it when you run "git status" command???)---is not careful enough to notice that it does not matter even if that leftover file is unusable.

Two issues "the sequencer" folks may want to address are

 (1) make the one that reads an irrelevant/stale 'todo' file more
     careful to ignore errors in such a file;

 (2) make the sequencer machinery more careful to clean up after it
     is done or it is aborted  (for example, "git reset --hard"
     could remove these state files preemptively even when a rebase
     is not in progress, I would think).

I think we already had some patches toward the latter recently.

Thanks for a report.