Re: [PATCH 0/1] diff: release all handles before running external diff
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 8, 2019, 19:24 UTC
- Message-ID
- <xmqqr270xrc5.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <pull.213.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
> On Windows, it is not possible to overwrite a file as long as any process > holds a read handle to it. Even keeping regions memory-mapped prevents that.
That second sentence was quite helpful, as I do recall us closing after mmapping. Without it, the justification becomes quite weak.