git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 19, 2019, 17:36 UTC
Message-ID
<xmqqr25hxdk6.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190816204906.GA29853@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I'm undecided on this. I think reftables are still a while off, and even
> once they are here, many people will still be using the older format. So
> it makes sense to still apply fixes to the old code.
Yeah.
Show 7 quoted lines
> What I wonder, though, is whether always refreshing will cause a
> noticeable performance impact (and that's why I was so slow in
> responding -- I had hoped to try to come up with some numbers, but I
> just hadn't gotten around to it).
>
> My gut says it's _probably_ not an issue, but it would be nice to have
> some data to back it up.

I am tempted to let correctness (and ease-of-reasoning about the code) take precedence over potential and unknown performance issue, at least for now. A single liner is rather simple to revert (or in the worst case we could add "allow pack-refs to efficiently lose a ref to a race" configuration option) anyway.

Previous: Jeff KingNext: 16657101987@163.com
Message 7 of 8 in “pack-refs: pack expired loose refs to packed_refs”
  1. 0/1 pack-refs: pack expired loose refs to packed_refs16657101987@163.com, Jul 21, 2019
  2. 1/1 pack-refs: pack expired loose refs to packed_refs16657101987@163.com, Jul 21, 2019
  3. Jeff KingJul 30, 2019
  4. 0/1 pack-refs: always refreshing after take the lock file16657101987@163.com, Jul 31, 2019
  5. 1/1 pack-refs: always refreshing after take the lock file16657101987@163.com, Jul 31, 2019
  6. Jeff KingAug 16, 2019
  7. Junio C HamanoAug 19, 2019
  8. 16657101987@163.comAug 20, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.