Re: [PATCH] git gui: fix branch name encoding error on git gui
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 9, 2019, 21:25 UTC
- Message-ID
- <xmqqr21dtcn7.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20191209210942.gcyp6ch7zingkhfs@yadavpratyush.com>
Pratyush Yadav <me@yadavpratyush.com> writes:
Show 7 quoted lines
> My position is that we should default to UTF-8 given its popularity (at > least in the Git world), but I'm wondering whether we should also add a > config variable to allow users to configure their encodings. > > If you don't mind, your thoughts on this would be appreciated :) > > [0] https://github.com/prati0100/git-gui/pull/21
Quite honestly, as long as we can keep the core part to stay "pathnames and refnames are just runs of bytes, terminated by NUL, and no other interpretation is necessary", I do not think I care too deeply if the UI layers (either GUI or Porcelain) become a bit more restrictive.
But that is just my gut feeling.