Re: [PATCH] bugreport: collect list of populated hooks

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2020, 20:46 UTC
Message-ID: <xmqqr1w87j2p.fsf@gitster.c.googlers.com>
In-Reply-To: <20200427190257.GA77802@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 15 quoted lines

>> > +	/*
>> > +	 * NEEDSWORK: Doesn't look like there is a list of all possible hooks;
>> > +	 * so below is a transcription of `git help hooks`. Later, this should
>> > +	 * be replaced with some programmatically generated list (generated from
>> > +	 * doc or else taken from some library which tells us about all the
>> > +	 * hooks)
>> > +	 */
>> 
>> Yes, I recall that we discussed adding some annotation to
>> documentation and extracting this automatically.
>
> Right, we did. I think I was hesitant to move on it because I had
> https://lore.kernel.org/git/20200420235310.94493-1-emilyshaffer@google.com
> on my back burner and wasn't sure how the hook architecture would look
> afterwards.

I thought we already agreed back then during that discussion I recalled that we'd leave that "single source of truth" unification out of the current topic. Unless anything has changed recently to bring us closer to be ready to start designing, I think it still is fine to keep the needs-work comment above and punting.

Thanks.