Re: [PATCH v4 1/2] hooks: allow input from stdin for commit-related hooks

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2020, 18:13 UTC
Message-ID: <xmqqr1onuc9w.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cS5BUCaFN=MN+7gSTbvskffRdTJOgck6TrRRacxCc_CwA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 10 quoted lines

> At the very least, this change deserves a documentation update, both
> to explain that the prepare-commit-msg hook has a valid stdin, and
> (importantly) that it won't be able to rely upon stdin in conjunction
> with `-F -`. (This also makes me wonder if it would be possible to
> signal to the hook whether or not stdin is available. Perhaps this
> could be done by passing an additional argument to the hook.)
>
> Finally, I realize that you followed Junio's suggestion for organizing
> the series, however, it feels undesirable for patch [1/2] to leave the
> command in a somewhat broken state, ...

True. The split you suggest sounds saner, if we were to still move forward with this change. I originally threw "commit -F -" in the "don't do it if it hurts" category, but I agree with you that it is quite plausible that IDE would want to use the feature to feed the log message to the command (that way they do not need to worry about a temporary file at all), so it can become a real issue.

Thanks.