Re: [PATCH v4 3/3] ls-files: add --deduplicate option

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2021, 06:25 UTC
Message-ID: <xmqqr1mkm65c.fsf@gitster.c.googlers.com>
In-Reply-To: <0c7830d07db0aa1ec055b97de52bd873d05e3ab1.1610856136.git.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -		}else if (show_modified && ie_modified(repo->index, ce, &st, 0))
> +			}
> +		} else if (show_modified && ie_modified(repo->index, ce, &st, 0))

The preimage shows a style violation "}else if" introduced by an earlier step in the series, and this fixes it.

Please make sure to proofread your patches before you show to others to pretend that you are perfect coder and do not need "oops what I did earlier in the series was wrong and here is a fix-up".

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.