Re: git-sh-prompt: bash: GIT_PS1_COMPRESSSPARSESTATE: unbound variable

From: Junio C Hamano <gitster@pobox.com>
Date: May 19, 2021, 23:29 UTC
Message-ID: <xmqqr1i2wbef.fsf@gitster.g>
In-Reply-To: <681aefe15af98f6758f28544b96bc2eca90642f3.camel@scientia.net>

Christoph Anton Mitterer <calestyo@scientia.net> writes:

Show 9 quoted lines

> Hey there.
>
> I think I found another case of an unbound variable:
>
> Completing e.g.:
> git commit --[press TAB]
>
> gives:
> $ git commit  --bash: GIT_COMPLETION_SHOW_ALL: unbound variable

It seems that OMIT_SPARSESTATE would have the same issue.

	if [ -z "${GIT_PS1_COMPRESSSPARSESTATE}" ] &&
	   [ -z "${GIT_PS1_OMITSPARSESTATE}" ] &&

all coming from afda36db (git-prompt: include sparsity state as well, 2020-06-21).

But I think we have already seen the fix in 5c0cbdb1 (git-prompt: work under set -u, 2021-05-13), which may or may not appear in the upcoming release.

There still are unprotected mentions of GIT_PS1_SHOWUPSTREAM even with that fix, though.