Re: [PATCH 0/2] CI: don't fail OSX tests due to brew v.s. perforce.com mis-match
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 21, 2022, 21:57 UTC
- Message-ID
- <xmqqr15qdrqm.fsf@gitster.g>
- In-Reply-To
- <cover-0.2-00000000000-20220421T124225Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 6 quoted lines
> Junio: Despite modifying CI stuff this series merges cleanly with > "seen", and has no semantic conflicts with any outstanding CI changes. > > For the past days we've again had CI failures due to "brew install" > detecting a SHA-256 mismatch when trying to install the perforce > package[1]. E.g. "seen" is now failing: https://github.com/git/git/runs/6104156856?check_suite_focus=true
Yup, it was something I've been disturbed by and planning to ping folks about if it continued.
Show 10 quoted lines
> This occurrence of this issue will no doubt be fixed within a few days > as the homebrew-cask repository is updated, i.e. this recipe: > https://github.com/Homebrew/homebrew-cask/commits/master/Casks/perforce.rb > > But for our CI usage being this anal about the check isn't worth it, > here's a passing CI run where we simply forced the installation: > ... > Ævar Arnfjörð Bjarmason (2): > CI: run "brew install perforce" without past workarounds > CI: don't care about SHA256 mismatch on upstream "perforce" package
I dunno. Does it open us to a new attack vector in some way?