Re: ab/test-without-templates

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2022, 22:12 UTC
Message-ID: <xmqqr13fxc5l.fsf@gitster.g>
In-Reply-To: <220623.86sfnvk5rw.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 19 quoted lines

> On Wed, Jun 22 2022, Junio C Hamano wrote:
>
>> * ab/test-without-templates (2022-06-06) 7 commits
>>  - tests: don't assume a .git/info for .git/info/sparse-checkout
>>  - tests: don't assume a .git/info for .git/info/exclude
>>  - tests: don't assume a .git/info for .git/info/refs
>>  - tests: don't assume a .git/info for .git/info/attributes
>>  - tests: don't assume a .git/info for .git/info/grafts
>>  - tests: don't depend on template-created .git/branches
>>  - t0008: don't rely on default ".git/info/exclude"
>>
>>  Tweak tests so that they still work when the "git init" template
>>  did not create .git/info directory.
>>
>>  Will merge to 'next'?
>>  source: <cover-v2-0.7-00000000000-20220603T110506Z-avarab@gmail.com>
>
> Presumably the submitters vote doesn't count for much, but FWIW I think
> it's ready & that there's nothing outstanding left to address.

I do not think they make any particular test to break, but I do not think it is a good idea overall to give a false impression to the users that it is OK to use incomplete templates that lack things expected by Git in properly initialized repositories. And these patches definitely take things in that wrong direction.