Re: [PATCH] unpack-trees: fix sparse directory recursion check

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 2, 2022, 16:57 UTC
Message-ID: <xmqqr10t90jb.fsf@gitster.g>
In-Reply-To: <8dea9ffe-d03b-f838-6cc5-db0de5024d9f@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 9 quoted lines

> Could it also happen if we are going from a commit without that
> sparse directory and then to a commit with that sparse directory? I
> think that would be a more common case, but I was unable to
> manipulate the test repo in t1092 to trigger this bug in the existing
> test cases.
>
> This makes me think that this bug _is_ extremely rare, so we don't
> need to rush this into a 2.37.4 or anything. It would be good to
> bring it into 2.38.0-rc0, though.

When the "test" part of the patch is applied directly on top of the vd/sparse-reset-checkout-fixes topic without its "fix" part, the newly added test fails, and with the "fix" part applied, everything goes peachy. I think applying it on top of the topic as a fix to it would be the most sensible. Any motivated distro packager can grab the topic and merge to their long-term maintenance track that way more easily.

Thanks all.