git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git_connect(): fix corner cases in downgrading v2 to v0

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 17, 2023, 22:15 UTC
Message-ID
<xmqqr0tnf2i2.fsf@gitster.g>
In-Reply-To
<ZBS6wwWXcEBwGBm/@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> There's code in git_connect() that checks whether we are doing a push
> with protocol_v2, and if so, drops us to protocol_v0 (since we only know
> how to do v0 for fetches).

I had to read this three times to make sense out of it, and then after reading the NEEDSWORK comment at the beginning of git_connect(), started to suspect that there is a bit of typo there that made it confusing to me. Either "(since we only know how to do v2 for fetches)", or "(since we only know how to push via v0)", perhaps.

Other than that, superb reasoning and a very clear solution. Will apply. Thanks.

Previous: Jeff KingNext: Jeff King
Message 2 of 3 in “git_connect(): fix corner cases in downgrading v2 to v0”
  1. git_connect(): fix corner cases in downgrading v2 to v0Jeff King, Mar 17, 2023
  2. Junio C HamanoMar 17, 2023
  3. Jeff KingMar 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.