Re: [PATCH v2] describe: enable sparse index for describe

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2023, 18:27 UTC
Message-ID: <xmqqr0t79zvm.fsf@gitster.g>
In-Reply-To: <8cb2b7a2-78f2-9221-1234-62814557d2d3@github.com>

Victoria Dye <vdye@github.com> writes:

Show 11 quoted lines

>> diff --git a/t/t6121-describe-sparse.sh b/t/t6121-describe-sparse.sh
>> new file mode 100755
>> index 00000000000..ce53603c387
>> --- /dev/null
>> +++ b/t/t6121-describe-sparse.sh
>
> Is there a specific reason you've created a new test file instead of adding
> the tests to 't1092-sparse-checkout-compatibility.sh'? Historically, ...
> ... 't1092' also uses a more "interesting" test repo &
> includes comparison functions for full checkout/sparse-checkout/sparse
> index, so the tests added for 'git describe' can be more thorough.

Ahh... I mentioned t6120 in my response, but t1092 does sound like a lot more appropriate place for adding tests for these.

Thanks for pointing it out.