git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] t0091-bugreport.sh: actually verify some content of report

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 5, 2023, 19:54 UTC
Message-ID
<xmqqr0pmyw0b.fsf@gitster.g>
In-Reply-To
<xmqqv8eyyw2g.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> I notice that "git version:" does not have its value on its line.
> Isn't it a bug we would rather fix before writing this "sanity check"
> test, I have to wonder.
 builtin/bugreport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git c/builtin/bugreport.c w/builtin/bugreport.c
index daf6c23657..af34dd6e1f 100644
--- c/builtin/bugreport.c
+++ w/builtin/bugreport.c
@@ -19,7 +19,7 @@ static void get_system_info(struct strbuf *sys_info)
 	char *shell = NULL;
 
 	/* get git version from native cmd */
-	strbuf_addstr(sys_info, _("git version:\n"));
+	strbuf_addstr(sys_info, _("git version: "));
 	get_version_info(sys_info, 1);
 
 	/* system call for other version info */
Previous: Junio C HamanoNext: Martin Ågren
Message 4 of 5 in “t0091-bugreport.sh: actually verify some content of report”
  1. t0091-bugreport.sh: actually verify some content of reportMartin Ågren, Jul 5, 2023
  2. Martin ÅgrenJul 5, 2023
  3. Junio C HamanoJul 5, 2023
  4. Junio C HamanoJul 5, 2023
  5. Martin ÅgrenJul 7, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.