git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] t2400: avoid using pipes

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2023, 18:42 UTC
Message-ID
<xmqqr0mbzgx5.fsf@gitster.g>
In-Reply-To
<CAPig+cSkZ_brRh_ijFRgz3sP9ou5se9-xeRg=C+cV3c3-v3Wtg@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 14 quoted lines
> On Tue, Oct 3, 2023 at 1:49 PM <ach.lumap@gmail.com> wrote:
>> t2400: avoid using pipes
>
> Pipes themselves are not necessarily problematic, and there are many
> places in the test suite where they are legitimately used. Rather...
> ...
> readers of `git log --oneline` (or other such commands), a better
> subject for the patch might be:
>
>     t2400: avoid losing Git exit code
>
> That minor comment aside (which is probably not worth a reroll), the
> commit message properly explains why this change is desirable and the
> patch itself looks good.
Thanks for writing and reviewing.  Will queue.
Previous: Eric SunshineNext: Achu Luma
Message 4 of 10 in “*** Avoid using Pipes ***”
  1. 0/1 *** Avoid using Pipes ***ach.lumap@gmail.com, Oct 3, 2023
  2. 1/1 t2400: avoid using pipesach.lumap@gmail.com, Oct 3, 2023
  3. Eric SunshineOct 3, 2023
  4. Junio C HamanoOct 3, 2023
  5. 0/1 *** Avoid using Pipes ***Achu Luma, Nov 30, 2023
  6. 1/1 t2400: avoid using pipesAchu Luma, Nov 30, 2023
  7. Christian CouderNov 30, 2023
  8. [Outreachy][PATCH v3] t2400: avoid using pipesAchu Luma, Dec 4, 2023
  9. Junio C HamanoDec 8, 2023
  10. [Outreachy][PATCH v4] t2400: avoid losing exit status to pipesAchu Luma, Jan 20, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.