Re: [PATCH 0/7] reftable: fixes and optimizations (pt.2)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 20, 2023, 19:10 UTC
- Message-ID
- <xmqqr0jgsn9g.fsf@gitster.g>
- In-Reply-To
- <cover.1703063544.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 8 quoted lines
> Patrick Steinhardt (7): > reftable/stack: do not overwrite errors when compacting > reftable/writer: fix index corruption when writing multiple indices > reftable/record: constify some parts of the interface > reftable/record: store "val1" hashes as static arrays > reftable/record: store "val2" hashes as static arrays > reftable/merged: really reuse buffers to compute record keys > reftable/merged: transfer ownership of records when iterating
Something like this need to be split and sprinkled into relevant steps in v2 in order to pass "make hdr-check", it seems.
reftable/reftable-record.h | 1 + reftable/reftable-stack.h | 1 + 2 files changed, 2 insertions(+)
diff --git c/reftable/reftable-record.h w/reftable/reftable-record.h index 83d252ec2c..fd1160615c 100644 --- c/reftable/reftable-record.h +++ w/reftable/reftable-record.h @@ -9,6 +9,7 @@ license that can be found in the LICENSE file or at #ifndef REFTABLE_RECORD_H #define REFTABLE_RECORD_H +#include <hash-ll.h> #include <stdint.h> /* diff --git c/reftable/reftable-stack.h w/reftable/reftable-stack.h index 1b602dda58..50b1a4f4dd 100644 --- c/reftable/reftable-stack.h +++ w/reftable/reftable-stack.h @@ -9,6 +9,7 @@ license that can be found in the LICENSE file or at #ifndef REFTABLE_STACK_H #define REFTABLE_STACK_H +#include <hash-ll.h> #include "reftable-writer.h" /*