git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] rebase: Fix documentation about used shell in -x

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 17, 2024, 22:38 UTC
Message-ID
<xmqqr0iftwk0.fsf@gitster.g>
In-Reply-To
<20240117085347.948960-1-nik.borisov@suse.com>
Nikolay Borisov <nik.borisov@suse.com> writes:
Show 7 quoted lines
> The shell used when using the -x option is erroneously documented to be
> the one pointed to by the $SHELL environmental variable. This was true
> when rebase was implemented as a shell script but this is no longer
> true.
>
> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
> ---

Ah, our mails crossed, and this is much better than my "tentative" one. Let me replace it with this one and queue.

Thanks.
Show 23 quoted lines
>  Documentation/git-rebase.txt | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
> index 25516c45d8b8..2cd55aedc0f9 100644
> --- a/Documentation/git-rebase.txt
> +++ b/Documentation/git-rebase.txt
> @@ -963,10 +963,9 @@ The interactive rebase will stop when a command fails (i.e. exits with
>  non-0 status) to give you an opportunity to fix the problem. You can
>  continue with `git rebase --continue`.
>
> -The "exec" command launches the command in a shell (the one specified
> -in `$SHELL`, or the default shell if `$SHELL` is not set), so you can
> -use shell features (like "cd", ">", ";" ...). The command is run from
> -the root of the working tree.
> +The "exec" command launches the command in a shell (the default one, usually
> +/bin/sh), so you can use shell features (like "cd", ">", ";" ...). The command
> +is run from the root of the working tree.
>
>  ----------------------------------
>  $ git rebase -i --exec "make test"
> --
> 2.34.1
Previous: Nikolay Borisov
Message 2 of 2 in “rebase: Fix documentation about used shell in -x”
  1. rebase: Fix documentation about used shell in -xNikolay Borisov, Jan 17, 2024
  2. Junio C HamanoJan 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.