git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: avoid using fixed-size buffer in write_out_one_reject()

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 16, 2024, 22:39 UTC
Message-ID
<xmqqr0f5c4q5.fsf@gitster.g>
In-Reply-To
<a93cd243-cb17-4ad5-8d23-30768dc5213b@web.de>
René Scharfe <l.s.r@web.de> writes:
> Take care to work around (arguably buggy) implementations of free(3)
> that change errno by calling it only after using the errno value.
;-).

The "do everything including giving an error message, jump to the exit label where resources are released just before returning" pattern naturally gives us that, which is very nice.

Will queue.  Thanks.
Previous: René Scharfe
Message 2 of 2 in “apply: avoid using fixed-size buffer in write_out_one_reject()”
  1. apply: avoid using fixed-size buffer in write_out_one_reject()René Scharfe, Apr 16, 2024
  2. Junio C HamanoApr 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.