git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] meson: ensure correct version-def.h is used

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 13, 2025, 17:01 UTC
Message-ID
<xmqqr056abry.fsf@gitster.g>
In-Reply-To
<20250113-toon-fix-meson-version-v1-1-9637e2be32e3@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
> have a `version-def.h` file in project root directory as well. Because
> `version-def.h` is included in `version.c` using the #include directive
> with double quotes, some compilers will look for the header file in the
> same directory as the source file.

What happens if we use <version-def.h> to include (which is how C standard tells us to do), with an explicit include path specified with -I<directory>? If it solves the issue, that may be a better approach.

Thanks.
Previous: Patrick SteinhardtNext: Toon Claes
Message 3 of 8 in “meson: ensure correct version-def.h is used”
  1. meson: ensure correct version-def.h is usedToon Claes, Jan 13, 2025
  2. Patrick SteinhardtJan 13, 2025
  3. Junio C HamanoJan 13, 2025
  4. Toon ClaesJan 13, 2025
  5. Patrick SteinhardtJan 14, 2025
  6. meson: ensure correct version-def.h is usedToon Claes, Jan 14, 2025
  7. Patrick SteinhardtJan 16, 2025
  8. Junio C HamanoJan 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.