git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 'seen' branch identifies as v2.48.0

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2025, 01:49 UTC
Message-ID
<xmqqr0566u60.fsf@gitster.g>
In-Reply-To
<6c5d0f90-79f0-4fba-8edb-f80d0665873b@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>   $ cat GIT-VERSION
>   v2.48.0
>   $ 

This came from semantic mismerge with Patrick's latest round of build updates. Usually I try to review very critically parts of a series that can negatively affect those users who do *not* use a new feature each topic tries to add or improve, and it means for this topic, if it breaks builds that do not involve meson, it would automatically qualify the topic to be ejected from the tree (side note: if a breakage is for those who use meson, as long as it is not as grave as running an equivalent of "sudo rm -fr /", I'll let it through), but this time because there was no textual conflict, the hardcoded GIT-VERSION unfortunately went through.

I however somehow thought that those who are building from a repository should get "git describe" name instead of the hardcoded fallback name in GIT-VERSION. At least, it is my understanding that is the intent of that series. Or are you building from a tarball extract?

> I normally like to find solutions before posting problems to the list, but
> unfortunately I don't have time to look into this at the moment. Sorry!
>
> Just a heads up.

I'd throw it back at Patrick, at least for tonight; the topic is more or less hot off the press and it should not be surprising it it needed immediate fix-up and reroll.

Thanks.
Previous: Ramsay JonesNext: Patrick Steinhardt
Message 2 of 4 in “'seen' branch identifies as v2.48.0”
  1. Ramsay JonesJan 14, 2025
  2. Junio C HamanoJan 14, 2025
  3. Patrick SteinhardtJan 14, 2025
  4. Ramsay JonesJan 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.