Re: [PATCH 2/2] merge-ort: fix slightly overzealous assertion for rename-to-self

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2025, 23:18 UTC
Message-ID: <xmqqr031x2gg.fsf@gitster.g>
In-Reply-To: <CABPp-BH+9JcP6FDP6RFQzZbwW=XOWnWAR8PmrCS6hG4iyd2pPQ@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 5 quoted lines

> But it might be worth mentioning that having side-effects in
> assertions is a huge no-no, and I understand that when folks have to
> debug one of those (I had to in a separate project years ago which was
> kind of nasty), that they sometimes jump to the conclusion that
> assertions are bad.

Yes, assert() invites such mistakes. Why not avoid them when there are better alternatives like "if (condition) BUG()"?