Re: [PATCH] builtin/gc: correct physical memory detection for OpenBSD / NetBSD

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2025, 02:00 UTC
Message-ID: <xmqqr002vr66.fsf@gitster.g>
In-Reply-To: <87h60z6i5o.fsf@gmail.com>

Collin Funk <collin.funk1@gmail.com> writes:

Show 16 quoted lines

> Hi Brad,
>
> You wrote:
>
>> OpenBSD / NetBSD use HW_PHYSMEM64 to detect the amount of physical
>> memory in a system. HW_PHYSMEM will not provide the correct amount
>> on a system with >=4GB of memory.
>>
>> Signed-off-by: Brad Smith <brad@comstyle.com>
>> ---
>> builtin/gc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I confirm this patch is correct.
>
> Reviewed-by: Collin Funk <collin.funk1@gmail.com>

Thanks (also thanks for the online_cpus() one).