Re: [PATCH v4 2/7] strbuf: split out logic to humanise byte values
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 16, 2025, 18:59 UTC
- Message-ID
- <xmqqqzsu2qxy.fsf@gitster.g>
- In-Reply-To
- <20251216173842.3357832-3-jltobler@gmail.com>
Justin Tobler <jltobler@gmail.com> writes:
Show 12 quoted lines
> +static void strbuf_humanise(struct strbuf *buf, off_t bytes, unsigned flags)
> +{
> + char *value;
> + const char *unit;
> +
> + humanise_bytes(bytes, &value, &unit, flags);
> +
> + /*
> + * TRANSLATORS: The first argument is the number string. The second
> + * argument is the unit prefix string (i.e. "12.34 MiB/s").
> + */
> + strbuf_addf(buf, _("%s %s"), value, unit);"unit prefix string"? Prefix is something that comes before something else, but this one is at the end. Simply saying a "unit string" would probably be a sufficient fix, perhaps?
I read the changes since the last round, and other than this part, everything looked good.
Thanks.