Re: [GSOC PATCH] t2003: modernize test path helpers

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2026, 08:35 UTC
Message-ID: <xmqqqzqu71qw.fsf@gitster.g>
In-Reply-To: <20260208202809.270523-1-bkkaracay@gmail.com>

Burak Kaan Karaçay <bkkaracay@gmail.com> writes:

> Subject: Re: [GSOC PATCH] t2003: modernize test path helpers

What we see in the patch are more uses of test path helpers, and nothing in these path helpers are changed at all.

    Subject: t2003: modernize path existence checks using test helpers

or something like that, perhaps.

> -	test ! -h path1 && test -d path1 &&
> -	test -f path1/file1 && test ! -f path2/file1
> +	test_path_is_dir_not_symlink path1 &&
> +	test_path_is_file path1/file1 && test_path_is_missing path2/file1

The above is a faithful rewrite, but as a separate patch to follow-up this file, the last line should be split into two, having one command on each line.

All changes in this patch looked good.  Will queue.

Thanks.