Re: [PATCH v2 2/2] odb: ignore refs of shallow and grafted alternates

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 15, 2026, 17:25 UTC
Message-ID: <xmqqqzhqoozj.fsf@gitster.g>
In-Reply-To: <20261015065754.GB1979109@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The thread has been talking about check_connected(), but the same
> problem applies to advertising alternates for transfer. But your fix
> here takes care of both, because it works at the lowest level. Good.

;-)

Show 7 quoted lines

> This is a direct test of --alternate-refs, which is probably reasonable
> and the simplest way of doing it. I think you could also construct a
> case where a fetch or push causes the recipient repo to be corrupted (it
> claimed to have object X because of the alternate, so the other side
> didn't send it, but since _we're_ not shallow, now fsck, etc, fails).
> But I don't think there's a particular need to construct that full case
> for the tests.

Yeah, thanks for thinking it through thoroughly. I appreciate it very much.