git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mv: let 'git mv file no-such-dir/' error out

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 4, 2013, 17:44 UTC
Message-ID
<xmqqpppclde1.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CACsJy8BdXkzzZpEaOvqkJ8ckubbQ0ArOMUT8qnMHMDscupfj_A@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 24 quoted lines
> On Wed, Dec 4, 2013 at 3:44 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Duy Nguyen <pclouds@gmail.com> writes:
>>
>>> On Tue, Dec 3, 2013 at 3:32 PM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
>>> There's something we probably should check. In d78b0f3 ([PATCH]
>>> git-mv: add more path normalization - 2006-08-16), it mentions about
>>>
>>> git mv something/ somewhere/
>>>
>>> there's no test in that commit so I don't know the actual input and
>>> expected outcome.
>>
>> To me, the expected outcome is "behave like Unix's mv" (which works with
>> or without the trailing slash if somewhere exists).
>>
>>> If "somewhere" is a directory, it errors out with this patch and works
>>> without it.
>>
>> I can't reproduce. I've added this to my patch (indeed, the area wasn't
>> well tested), and the tests pass.
>
> Now I can't either. Probably some mis-setups or some local bugs in my
> tree. Good that we have more tests.
OK, I was also scratching my head after seeing your response.

It seems that t7001 needs some face-lifting, by the way. Perhaps after this patch solidifies.

Previous: Matthieu MoyNext: Matthieu Moy
Message 6 of 11 in “mv: let 'git mv file no-such-dir/' error out”
  1. mv: let 'git mv file no-such-dir/' error outMatthieu Moy, Dec 3, 2013
  2. Duy NguyenDec 3, 2013
  3. Matthieu MoyDec 4, 2013
  4. Duy NguyenDec 4, 2013
  5. mv: let 'git mv file no-such-dir/' error outMatthieu Moy, Dec 4, 2013
  6. Junio C HamanoDec 4, 2013
  7. Matthieu MoyDec 4, 2013
  8. mv: let 'git mv file no-such-dir/' error out on Windows, tooJohannes Sixt, Jan 8, 2014
  9. Junio C HamanoJan 9, 2014
  10. Johannes SixtJan 10, 2014
  11. Junio C HamanoJan 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.