Re: [PATCH] tag: add -i and --introduced modifier for --contains

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2014, 17:58 UTC
Message-ID: <xmqqppk95jrj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140422102713.GC366@quack.suse.cz>

Jan Kara <jack@suse.cz> writes:

Show 14 quoted lines

> On Thu 17-04-14 10:04:52, Junio C Hamano wrote:
>> So perhaps the rule should be updated to do something like:
>> 
>>     - find candidate tags that can be used to "describe --contains"
>>       the commit A, yielding v3.4, v3.5 (not shown), and v9.0;
>> 
>>     - among the candidate tags, cull the ones that contain another
>>       candidate tag, rejecting v3.5 (not shown) and v9.0;
>>
>>     - among the surviving tags, pick the closest.
> ...
> Regarding the strategy what to select when there are several
> remaining tags after first two steps I would prefer to output all such
> tags.

Yes, as I mentioned in another subthread ($gmane/246488), different projects want different tie-breaking rules at the third step, and your "show all to give more information to the user" could be another mode of operation.

I offhand do not think the current name-rev machinery is set up to compute your variant easily, though.