Re: [PATCH v4 2/2] test/send-email: to-cover, cc-cover tests
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2014, 19:01 UTC
- Message-ID
- <xmqqppk0j6yx.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1398750059-11955-2-git-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
Show 24 quoted lines
> Add tests for the new feature.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> t/t9001-send-email.sh | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 1ecdacb..97cc094 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -1334,6 +1334,51 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' '
> test -n "$(ls msgtxt*)"
> '
>
> +test_cover_addresses () {
> + header="$1"
> + shift
> + clean_fake_sendmail &&
> + rm -fr outdir &&
> + git format-patch --cover-letter -2 -o outdir &&
> + cover=`echo outdir/0000-*.patch` &&
> + mv $cover cover-to-edit.patch &&
> + sed "s/^From:/$header: extra@address.com\nFrom:/" cover-to-edit.patch > $cover &&Please do the redirection like this:
sed "s/^From:/$header: extra@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&
in your later patches (I'll tweak this patch myself, so no need to resend). We know >$cover should be the same as >"$cover", but it was reported that some version of bash does not know it and complains instead (see Documentation/CodingGuidelines).