Re: [PATCH v7 5/8] config: add `git_die_config()` to the config-set API

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 5, 2014, 16:42 UTC
Message-ID: <xmqqppgeq465.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqiom72cj4.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 17 quoted lines

> Tanay Abhra <tanayabh@gmail.com> writes:
>
>> Currently works like the old git_config() error reporting path. If err is set to "NULL",
>> it would print no error message and just the die message. If given something like,
>>
>> 	 git_config_die(key, "value '%s' is not allowed", value);
>>
>> it would print,
>>
>> 	error: value '3' is not allowed
>> 	fatal: bad config variable 'core.frotz' at file line 15 in .git/config
>
> That seems to be a good step forward.
>
> I think we would also want to improve the error message, but that
> shouldn't block your series from inclusion: we can do that later without
> API change.

Yup, I agree with your assessment.

Thank you, both, for good polishing.