git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git format-patch --in-reply-to allows header injection. Intended?

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 4, 2014, 21:36 UTC
Message-ID
<xmqqppfbqd9x.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5408D7ED.9010203@nh2.me>
Niklas Hambüchen <mail@nh2.me> writes:
Show 5 quoted lines
> For example, if you pass "--in-reply-to=<msgid>\nTo: <other@example.com"
> (notice lack of trailing `>`), then the generated email will actually
> contain a
>   To: <other@example.com>
> header.

While I do not think of a reason to specify such a string to the in-reply-to option (I'd rather edit the output in the editor if I wanted to do anything fancy [*1*]), I do not think there is a reason why you want to add a code to forbid such use, either.

[Footnote]
*1* For that matter, --in-reply-to option itself is superfluous.
Previous: Niklas HambüchenNext: Niklas Hambüchen
Message 2 of 4 in “git format-patch --in-reply-to allows header injection. Intended?”
  1. Niklas HambüchenSep 4, 2014
  2. Junio C HamanoSep 4, 2014
  3. Niklas HambüchenSep 4, 2014
  4. Junio C HamanoSep 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.