Re: [PATCH] remote.c - Make remote definition require a url
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 13, 2014, 17:19 UTC
- Message-ID
- <xmqqppdv51lv.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1413040849-20056-1-git-send-email-mlevedahl@gmail.com>
Mark Levedahl <mlevedahl@gmail.com> writes:
> Some options may be configured globally for a remote (e.g, tagopt).
Or some remotes may have only pushurl and not url. "git remote" output for me has a few such remotes but wouldn't this patch break it?
If a caller that walks the list of remotes misbehaves only because it assumes that r->url always is always valid, isn't that assumption what needs to be fixed? for_each_remote() should be kept as a way to enumerate all the [remote "foo"], I would think.