Re: [PATCH 2/2] .mailmap: Add Stefan Bellers corporate mail address
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 21, 2014, 05:53 UTC
- Message-ID
- <xmqqppdm0y02.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1413856245-5443-2-git-send-email-stefanbeller@gmail.com>
Stefan Beller <stefanbeller@gmail.com> writes:
Show 5 quoted lines
> From: Stefan Beller <sbeller@google.com> > > Note that despite the private address being first, Google owns the > copyright on this patch as any other patch I'll be sending signed off > by the sbeller@google.com address.
While Googlers are encouraged to interact with external open source projects using their corp address when working as new contributors, Googlers are also encouraged to keep using the same pre-corp address when working with projects they have been part of for continuity.
After all, even if you send patches from your @gmail.com address while being employed by Google, the patches are copyright Google, not yours, and DCO (a) "I have the right to submit" covers your submissions just fine (i.e. it does not say "I own the copyright"), as long as you are cleared to contribute your patches to us by Google's open source office (which I happen to know that you have already done).
The mailmap is primarily to correct past mistakes and document the new addresses of those who lost the old address to maintain their reachability. It is not about planning to send patches from two different addresses chosen by the phase of the moon or something.
I do not terribly mind, but is this patch really necessary?
Show 18 quoted lines
> > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap b/.mailmap > index 8aefb5a..bb6f52e 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -205,6 +205,7 @@ Shawn O. Pearce <spearce@spearce.org> > Simon Hausmann <hausmann@kde.org> <simon@lst.de> > Simon Hausmann <hausmann@kde.org> <shausman@trolltech.com> > Stefan Beller <stefanbeller@gmail.com> <stefanbeller@googlemail.com> > +Stefan Beller <stefanbeller@gmail.com> <sbeller@google.com> > Stefan Naewe <stefan.naewe@gmail.com> <stefan.naewe@atlas-elektronik.com> > Stefan Naewe <stefan.naewe@gmail.com> <stefan.naewe@googlemail.com> > Stefan Sperling <stsp@elego.de> <stsp@stsp.name>