Re: [PATCH/RFC] rerere: error out on autoupdate failure

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2014, 17:41 UTC
Message-ID: <xmqqppc0iqb7.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqy4qoiqmu.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> Instead of crafting a new message, why not just stop passing IGNORE_ERRORS
> and have add_file_to_cache() report the failure?  That is:
>
> 	if (add_file_to_cache(item->string, 0))
>         	return -1;

Err, that should be exit(128) to mimic die().

> That way, the user will get more useful diagnosis because there are
> different reasons why an "add" may fail and we give different error
> messages to them.