git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Question about the revision walking API

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 6, 2015, 18:30 UTC
Message-ID
<xmqqpparpxrr.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAP8UFD0mZ4tSF-ZkZh8Z=GdkW4LNQAWuKJYyhyiA4RTGPLX_+g@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
> I am not sure what you describe above would work, but something like
> what is done in bisect.c should work, see check_ancestors() and
> bisect_next_all(). It might not be the most efficient solution though,
> so I am interested if you find something more efficient.

I do not think what bisect does is a correct solution for general case; I didn't check too carefully when I applied your patch long time ago, but I recall that you only clear flag bits from commits that are still in the pending queue in that codepath. That may be sufficient if the subsequent traversal goes only outside the area previous traversal walked, but the approach is inappropriate for general cases, no?

Previous: Christian Couder
Message 5 of 5 in “Question about the revision walking API”
  1. Mike HommeyJan 6, 2015
  2. Junio C HamanoJan 6, 2015
  3. Mike HommeyJan 6, 2015
  4. Christian CouderJan 6, 2015
  5. Junio C HamanoJan 6, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.