git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Error when cloning with weird local directory

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 6, 2015, 07:50 UTC
Message-ID
<xmqqpp30zwhu.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqqtwsczws6.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> It looks as if
>> static char *get_repo_path(const char *repo, int *is_bundle)
>> in built/clone.c
>> checks if there is a local directory structure looking like a
>> .git directory.
>> This is wrong.
>
> It is as designed, though, to allow cloning from a local directory
> with any name.
>
>> There should be a check for the scheme first.
>
> That will be wrong.
It matters mostly when dealing with scp-like syntax, word:path.

I _think_ taking notice of "word://" (with doubled slashes) and treating it specially will not introduce any new issue; while it is still OK for users to have a local directory called "word:", if they meant a subdirectory of it, they wouldn't have typed double-slashes there.

Previous: Junio C HamanoNext: Torsten Bögershausen
Message 4 of 6 in “Error when cloning with weird local directory”
  1. Chris PackhamAug 6, 2015
  2. Torsten BögershausenAug 6, 2015
  3. Junio C HamanoAug 6, 2015
  4. Junio C HamanoAug 6, 2015
  5. Torsten BögershausenAug 8, 2015
  6. Junio C HamanoAug 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.