Re: [PATCH 5/7] submodule: implement `module_list` as a builtin helper

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2015, 18:17 UTC
Message-ID: <xmqqpp2j9m7g.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1439857323-21048-6-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 18 quoted lines

> +static int module_list_compute(int argc, const char **argv,
> +				const char *prefix,
> +				struct pathspec *pathspec)
> +{
> +	int i;
> +	char *max_prefix, *ps_matched = NULL;
> +	int max_prefix_len;
> +	parse_pathspec(pathspec, 0,
> +		       PATHSPEC_PREFER_FULL |
> +		       PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP,
> +		       prefix, argv);
> +
> +	/* Find common prefix for all pathspec's */
> +	max_prefix = common_prefix(pathspec);
> +	max_prefix_len = max_prefix ? strlen(max_prefix) : 0;
> +
> +	if (pathspec->nr)
> +		ps_matched = xcalloc(1, pathspec->nr);

Micronit. Even though multiplication is commutative, the order of arguments to xcalloc() looks odd. It lets you say "I want an array with nmemb elements, and each of its is size-bytes long" by giving it nmemb and then size.

No need to resend; will fix it up while queuing.

Thanks.