Re: Minor bug with help.autocorrect.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2015, 06:36 UTC
Message-ID: <xmqqpp2d5h22.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150824054327.GB14403@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> Yeah, I agree these are the only two sane fixes. Plumbing the quiet flag
> through does seem really invasive; every "git_config_get_foo" variant
> would have to learn it. Probably it's too gross to have a global like:
>
>   config_lax_mode = 1;
>   git_config_get_string(key.buf, &v);
>   config_lax_mode = 0;
>
> That makes a nice tidy patch, but I have a feeling we would regret it
> later. :)

Yeah, I do think the double-checking the patch in your follow-up does is not so bad. Thanks for following it through (now I must remember not to drop these patches ;-).