Re: An idea for the "Leftover Bits": rebase -x to imply -i

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2016, 22:33 UTC
Message-ID: <xmqqpouu2guc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZg3QkfjB1hwZKRS9Hqg-1H=kQwuwByX_rAMzveXtnp7Q@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> * "rebase -exec" requiries to be an explicit interactive rebase (i.e.
>   --interactive was given)
>   Could --exec just imply --interactive with a no-op editor?

Perhaps like this? You have to defend the change with a good description, have to protect the new behaviour with a new test from future breakages, and may have to adjust existing tests if they are expecting the current behaviour (I didn't test).

 git-rebase.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-rebase.sh b/git-rebase.sh
index cf60c43..c68baa0 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -248,6 +248,7 @@ do
 		;;
 	--exec=*)
 		cmd="${cmd}exec ${1#--exec=}${LF}"
+		interactive_rebase=explicit
 		;;
 	--interactive)
 		interactive_rebase=explicit