Re: [PATCH] git-send-pack: Fix --all option when used with directory

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2016, 16:11 UTC
Message-ID: <xmqqpoujama8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1458750262-25765-1-git-send-email-stanislav@assembla.com>

Stanislav Kolotinskiy <stanislav@assembla.com> writes:

> Subject: Re: [PATCH] git-send-pack: Fix --all option when used with directory

Please see "git shortlog --no-merges" output from recent history and notice that s/Fix/fix/ would make things more consistent.

Show 8 quoted lines

> When using git send-pack with --all option and a target directory,
> usage message is being displayed instead of performing the actual
> transmission.
>
> The reason for this issue is that refspecs variable is being
> calculated in a different way comparing to previous versions, and
> even though the number of refspecs (nr_refspecs) is 0, refspecs
> contain all the arguments and switches passed to send-pack.

Thanks for noticing; the above explanation however does not make it very clear why the symptom exhibits itself only when "directory" is given (it also is unclear if "target" being a directory is special, or if any remote repository specification, e.g. host:/path/to/dir, triggers the same problem).